Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking TC-type configs #351

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Reworking TC-type configs #351

merged 5 commits into from
Oct 21, 2024

Conversation

ArturSztuc
Copy link
Contributor

@ArturSztuc ArturSztuc commented Oct 21, 2024

This PR has to go together with:

  1. Reworking TC-type configs appmodel#150
  2. Reworking TC-type configs daqsystemtest#136

Done:

  1. Reworked TCProcessor and RandomTCMaker configurations to use string-based TC-type inputs, rather than integer-based.
  2. Removed use_readout_map and use_roi_readout from configuration inputs: now assumed to be True if readout map or roi map is provided.
  3. Changed Trigger configuration error message.

Tests:

  1. Compiles.
  2. pytest -s ${DAQSYSTEMTEST_SHARE}/integtest/3ru_3df_multirun_test.py runs
  3. Changed TC-types in the configurations, ran a test session, and confirmed correct outputs with HDF5LIBS_TestDumpRecord.

Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested using daqsystemtest and local sessions with varying configurations. Local sessions were confirmed using trgtools.

@ArturSztuc ArturSztuc merged commit 5077483 into develop Oct 21, 2024
1 of 2 checks passed
@ArturSztuc ArturSztuc deleted the asztuc/mlt_tctype_rework branch October 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants